OufOfBcCheck for FEE modules#1774
Merged
Merged
Conversation
Extend GenericCheck with check of ratio of bins behind given value. Add specific check for TriggersSoftwareVsTCM MO.
Add parametrization of both min and max gate time for EventInGateTime hist.
afurs
reviewed
May 18, 2023
Comment on lines
+83
to
+88
| try { | ||
| bin = std::stoi(metainfo.first); | ||
| value = std::stof(metainfo.second); | ||
| } catch (const std::invalid_argument& e) { | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
I guess exception will break the run. Maybe better to send error message into InfoLogger?
Contributor
Author
There was a problem hiding this comment.
Exception shouldn't brake the run, only pass actual 'for' run. However there was a bug related to wrong metadata key. It was fixed by latest commit.
Barthelemy
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new check - OutOfBunchCollFeeModulesCheck which will allow user to compare ratio of collisions out of the bunch to all collisions per FEE module.
This check shall be run on new histogram created by PostProcessingTask - OutOfBunchColl_BCvsFeeModules